[webkit-changes] [WebKit/WebKit] 9eeb1f: [UI-side compositing] fast/repaint/canvas-object-f...

Said Abou-Hallawa noreply at github.com
Tue Mar 21 12:46:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9eeb1f044a729b3ccdaf67578a0337cea9116d3a
      https://github.com/WebKit/WebKit/commit/9eeb1f044a729b3ccdaf67578a0337cea9116d3a
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
    M LayoutTests/fast/repaint/canvas-object-fit.html
    M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  -----------
  [UI-side compositing] fast/repaint/canvas-object-fit.html fails on macOS due to a missing repaint rect
https://bugs.webkit.org/show_bug.cgi?id=254200
rdar://103582615

Reviewed by Simon Fraser.

With UI-side compositing, the two JS functions in the test are combined in one
updateRendering(). So we report one repaint rect which the entire canvas rect.
There is no user problem here but the test does not generate exactly the expected
output.

The fix is to make the first JS function run in the first updateRendering() loop
instead of running it onload. To fix the test for WK1, two requestAnimationFrame()
need to be scheduled before runing the first JS function.

* LayoutTests/fast/repaint/canvas-object-fit.html:
* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/261933@main




More information about the webkit-changes mailing list