[webkit-changes] [WebKit/WebKit] 3b8473: Correct WebKit Built-in PDF Plugin Naming

Commit Queue noreply at github.com
Tue Mar 21 11:17:19 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b84731a5f6a0a38b6f48a16ab927e5dbcb5c770
      https://github.com/WebKit/WebKit/commit/3b84731a5f6a0a38b6f48a16ab927e5dbcb5c770
  Author: Brent Fulgham <bfulgham at webkit.org>
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/LocalizedStrings.h
    M Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm

  Log Message:
  -----------
  Correct WebKit Built-in PDF Plugin Naming
https://bugs.webkit.org/show_bug.cgi?id=254189
<rdar://106476286>

Reviewed by Alexey Proskuryakov.

In Bug 245396, we revised our Navigator.plugins response to better match the standard.
Unfortunately, I made the label Localized, which provides a language-specific label for
this plugin.

However, since https://html.spec.whatwg.org/multipage/system-state.html#pdf-viewing-support
only mentions the English text, my localized version confuses some anti-fraud website logic.

This change removes that translation and simply hard-codes the text as defined in the
standard.

* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::builtInPDFPluginName): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pluginInfo):

Canonical link: https://commits.webkit.org/261928@main




More information about the webkit-changes mailing list