[webkit-changes] [WebKit/WebKit] 75336e: [ews-build.webkit.org] Install pre-push hook

Jonathan Bedard noreply at github.com
Tue Mar 21 09:52:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75336e867e1978743991b08f7df8b5a7f1c01626
      https://github.com/WebKit/WebKit/commit/75336e867e1978743991b08f7df8b5a7f1c01626
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
    M Tools/CISupport/ews-build/factories.py
    M Tools/CISupport/ews-build/factories_unittest.py
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [ews-build.webkit.org] Install pre-push hook
https://bugs.webkit.org/show_bug.cgi?id=254167
rdar://106954459

Reviewed by Aakash Jain.

The pre-push hook in the WebKit repository prevents users
from inadvertently publishing content from a secure remote.
EWS (merge-queue, in particular) should receive the same
protection.

* Tools/CISupport/ews-build/factories.py:
(Factory.__init__): Add InstallHooks step.
(StyleFactory.__init__): Ditto.
(WatchListFactory.__init__): Ditto.
(CommitQueueFactory.__init__): Ditto.
(MergeQueueFactoryBase.__init__): Ditto.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps): Add install-hooks step.
* Tools/CISupport/ews-build/steps.py:
(InstallHooks.__init__):
(InstallHooks.run): Add explicit 'level' option to
enable pushing the current change to the target remote.
(InstallHooks.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/261923@main




More information about the webkit-changes mailing list