[webkit-changes] [WebKit/WebKit] 2972c6: [media controls] overflow button appears clipped o...

Antoine Quint noreply at github.com
Tue Mar 21 02:53:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2972c6591e214a15e9bec189e9c679ff44bbc8c5
      https://github.com/WebKit/WebKit/commit/2972c6591e214a15e9bec189e9c679ff44bbc8c5
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
    A LayoutTests/media/modern-media-controls/overflow-support/dropped-when-narrow-expected.txt
    A LayoutTests/media/modern-media-controls/overflow-support/dropped-when-narrow.html
    M Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js

  Log Message:
  -----------
  [media controls] overflow button appears clipped on Google Research page
https://bugs.webkit.org/show_bug.cgi?id=254165
rdar://104744690

Reviewed by Devin Rousso.

We must account for _visible_ children when determining whether the right bar container should be shown.

* LayoutTests/media/modern-media-controls/overflow-support/dropped-when-narrow-expected.txt: Added.
* LayoutTests/media/modern-media-controls/overflow-support/dropped-when-narrow.html: Added.
* Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype.layout):

Canonical link: https://commits.webkit.org/261912@main




More information about the webkit-changes mailing list