[webkit-changes] [WebKit/WebKit] 1b354f: Use CheckedRef for m_documentLoader in Application...

JC Alvarado noreply at github.com
Mon Mar 20 16:47:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b354fa4ac8a76b80ec9678da8d00c67adca663a
      https://github.com/WebKit/WebKit/commit/1b354fa4ac8a76b80ec9678da8d00c67adca663a
  Author: JC Alvarado <joncarlo at apple.com>
  Date:   2023-03-20 (Mon, 20 Mar 2023)

  Changed paths:
    M Source/WebCore/loader/DocumentLoader.h
    M Source/WebCore/loader/appcache/ApplicationCacheHost.cpp
    M Source/WebCore/loader/appcache/ApplicationCacheHost.h

  Log Message:
  -----------
  Use CheckedRef for m_documentLoader in ApplicationCacheHost
https://bugs.webkit.org/show_bug.cgi?id=254086
rdar://106870953

Reviewed by Ryosuke Niwa.

DocumentLoader is RefCountable so we should use a smart pointer for
ApplicationCacheHost's m_documentLoader member variable.

* Source/WebCore/loader/DocumentLoader.h:
* Source/WebCore/loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::ApplicationCacheHost):
(WebCore::ApplicationCacheHost::selectCacheWithoutManifest):
(WebCore::ApplicationCacheHost::selectCacheWithManifest):
(WebCore::ApplicationCacheHost::canLoadMainResource):
(WebCore::ApplicationCacheHost::maybeLoadMainResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainResponse):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForMainError):
(WebCore::ApplicationCacheHost::maybeLoadResource):
(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):
(WebCore::ApplicationCacheHost::maybeLoadSynchronously):
(WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
(WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::update):
(WebCore::ApplicationCacheHost::swapCache):
(WebCore::ApplicationCacheHost::abort):
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
(WebCore::ApplicationCacheHost::isApplicationCacheBlockedForRequest):
* Source/WebCore/loader/appcache/ApplicationCacheHost.h:

Canonical link: https://commits.webkit.org/261896@main




More information about the webkit-changes mailing list