[webkit-changes] [WebKit/WebKit] 1ed989: REGRESSION iOS 16.4 beta selects ultra-wide for fa...
youennf
noreply at github.com
Mon Mar 20 10:07:33 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1ed9893d37379f00ccdfb1da94c568bf4be79ef6
https://github.com/WebKit/WebKit/commit/1ed9893d37379f00ccdfb1da94c568bf4be79ef6
Author: Youenn Fablet <youennf at gmail.com>
Date: 2023-03-20 (Mon, 20 Mar 2023)
Changed paths:
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
Log Message:
-----------
REGRESSION iOS 16.4 beta selects ultra-wide for facingMode: environment
https://bugs.webkit.org/show_bug.cgi?id=253186
rdar://problem/106142457
Reviewed by Jer Noble.
For ultra wide back cameras, add a zoomn factor of 2 so that a zoom of 1 corresponds to a standard FOV.
We compute this factor once and we then divide by this factor for capabilities and multiply by this factor for settings.
Manually tested on device.
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::computeMinZoom const):
(WebCore::AVVideoCaptureSource::computeMaxZoom const):
(WebCore::cameraZoomScaleFactor):
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::setFrameRateAndZoomWithPreset):
(WebCore::AVVideoCaptureSource::generatePresets):
(WebCore::computeMaxZoom): Deleted.
Canonical link: https://commits.webkit.org/261877@main
More information about the webkit-changes
mailing list