[webkit-changes] [WebKit/WebKit] a10ddc: [RenderTreeNeedsLayoutChecker] Add damaged inline ...

Alan Baradlay noreply at github.com
Mon Mar 20 07:05:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a10ddc56e6530f4e7b9963eb97f810d98e2abc2a
      https://github.com/WebKit/WebKit/commit/a10ddc56e6530f4e7b9963eb97f810d98e2abc2a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-20 (Mon, 20 Mar 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
    M Source/WebCore/page/LocalFrameViewLayoutContext.cpp

  Log Message:
  -----------
  [RenderTreeNeedsLayoutChecker] Add damaged inline display tree check
https://bugs.webkit.org/show_bug.cgi?id=254137

Reviewed by Antti Koivisto.

This checks the unexpected state when
1, inline content is damaged by destroyed renderer(s)
2, we fail to mark the containing block dirty (see webkit.org/b/254090)
3, subsequent layout does not reach the damaged inline content (see #2)
4, inline display content becomes stale

* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineDamage.h:
(WebCore::Layout::InlineDamage::hasDetachedContent const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
(WebCore::LayoutIntegration::LineLayout::hasDetachedContent const):
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker):
(WebCore::LocalFrameViewLayoutContext::performLayout):

Canonical link: https://commits.webkit.org/261869@main




More information about the webkit-changes mailing list