[webkit-changes] [WebKit/WebKit] 1bcce7: RenderObject::markContainingBlocksForLayout should...

Alan Baradlay noreply at github.com
Sun Mar 19 22:19:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bcce795a28b3014c784b5bf329c5591c08d6a14
      https://github.com/WebKit/WebKit/commit/1bcce795a28b3014c784b5bf329c5591c08d6a14
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-19 (Sun, 19 Mar 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  RenderObject::markContainingBlocksForLayout should check for non-positioned RenderLineBreaks too (and not just for RenderText)
https://bugs.webkit.org/show_bug.cgi?id=254090

Reviewed by Antti Koivisto.

Do not use the computed value for out-of-flow position as some of the renderers may override it (e.g. RenderLineBreak). Using incorrect containing blocks while dirtying the ancestor chain puts the render tree to an unexpected state.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):

Canonical link: https://commits.webkit.org/261859@main




More information about the webkit-changes mailing list