[webkit-changes] [WebKit/WebKit] 81f3db: AX: Remove unnecessarily cached AXPropertyName::Co...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81f3db0a48f4a0be08196ae002dfb9f3b41a0df7
      https://github.com/WebKit/WebKit/commit/81f3db0a48f4a0be08196ae002dfb9f3b41a0df7
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-03-19 (Sun, 19 Mar 2023)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Remove unnecessarily cached AXPropertyName::ComputedRoleString
https://bugs.webkit.org/show_bug.cgi?id=254131
rdar://problem/106909555

Reviewed by Chris Fleizach.

This property is only ever used by layout tests, not VoiceOver, so we
shouldn't spend the memory or CPU to cache it.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::computedRoleString const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::computedRoleString const):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper _computedRoleString]):
Rename `computedRoleString` to `_computedRoleString` to signify it's
private and AX clients shouldn't use it.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper computedRoleString]): Deleted.

Canonical link: https://commits.webkit.org/261856@main