[webkit-changes] [WebKit/WebKit] d55ce0: [ManagedMSE] network transfer should be tagged as ...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d55ce0bd5ffa26e832da01f2e8d81724311aedd8
      https://github.com/WebKit/WebKit/commit/d55ce0bd5ffa26e832da01f2e8d81724311aedd8
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-03-19 (Sun, 19 Mar 2023)

  Changed paths:
    M Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp
    M Source/WebCore/Modules/mediasource/ManagedMediaSource.h
    M Source/WebCore/Modules/mediasource/MediaSource.cpp
    M Source/WebCore/Modules/mediasource/MediaSource.h
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebKit/file-with-managedmse.html
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm

  Log Message:
  -----------
  [ManagedMSE] network transfer should be tagged as media between startstreaming/endstreaming events
https://bugs.webkit.org/show_bug.cgi?id=253996
rdar://106783581

Reviewed by Jer Noble.

Narrow detection of media related streaming activity to only be set
while the ManagedMediaSource's streaming activity is true.
With plain MSE we keep the existing behaviour.

Fly-by fix: when the MediaSource was ended, `endstreaming` wasn't fired
even if the entire file content had been buffered already.

API test added.

* Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp:
(WebCore::ManagedMediaSource::setStreaming):
(WebCore::ManagedMediaSource::monitorSourceBuffers):
(WebCore::ManagedMediaSource::startStreaming): Deleted.
(WebCore::ManagedMediaSource::endStreaming): Deleted.
* Source/WebCore/Modules/mediasource/ManagedMediaSource.h:
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDurationInternal):
* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaState const):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKit/file-with-managedmse.html: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/261850@main