[webkit-changes] [WebKit/WebKit] ceda77: [IFC][Partial layout] Bail out on <br> with "posit...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ceda77ba5b2cdc8e66d58239f2cbdd7dd98bd149
      https://github.com/WebKit/WebKit/commit/ceda77ba5b2cdc8e66d58239f2cbdd7dd98bd149
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-19 (Sun, 19 Mar 2023)

  Changed paths:
    A LayoutTests/fast/inline/out-of-flow-line-break-crash-expected.txt
    A LayoutTests/fast/inline/out-of-flow-line-break-crash.html
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

  Log Message:
  -----------
  [IFC][Partial layout] Bail out on <br> with "position: fix/absolute"
https://bugs.webkit.org/show_bug.cgi?id=254092
<rdar://106849017>

Reviewed by Antti Koivisto.

While all line breaks are treated as inflow, when "position: fix/absolute" is set on a <br> some of the rendering code, including markContainingBlocksForLayout sees it as out-of-flow content and leaves the tree in an unexpected state (when invalidating the line layout codepath (and by that nuking the line content) we simply early where due to the lack of line content -probably crash the same way in legacy).
Let's bail out of "out-of-flow" <br> for now (until webkit.org/b/254090 is fixed)

* LayoutTests/fast/inline/out-of-flow-line-break-crash-expected.txt: Added.
* LayoutTests/fast/inline/out-of-flow-line-break-crash.html: Added.
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor):

Canonical link: https://commits.webkit.org/261842@main