[webkit-changes] [WebKit/WebKit] e4fbd9: Replacing hard-coded list-style-types by predefine...

Vitor Roriz noreply at github.com
Sat Mar 18 08:54:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4fbd95a91f2f73d0cf4fb7221ce4b58560a4fb6
      https://github.com/WebKit/WebKit/commit/e4fbd95a91f2f73d0cf4fb7221ce4b58560a4fb6
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2023-03-18 (Sat, 18 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/fast/lists/decimal-leading-zero-expected.txt
    M LayoutTests/fast/lists/decimal-leading-zero.html
    M Source/WebCore/css/CSSCounterStyle.cpp
    M Source/WebCore/css/CSSCounterStyle.h
    M Source/WebCore/css/CSSCounterStyleRegistry.cpp
    M Source/WebCore/css/CSSCounterStyleRegistry.h
    M Source/WebCore/css/counterStyles.css
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/FontAttributes.h
    M Source/WebCore/editing/cocoa/FontAttributesCocoa.mm
    M Source/WebCore/rendering/RenderListMarker.cpp
    M Source/WebCore/rendering/RenderListMarker.h
    M Source/WebCore/rendering/style/ListStyleType.cpp
    M Source/WebCore/rendering/style/ListStyleType.h
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Replacing hard-coded list-style-types by predefined counter-styles
https://bugs.webkit.org/show_bug.cgi?id=254111
rdar://106085436

Reviewed by Tim Nguyen.

This patch makes the list-style-types
that are supported by predefined counter-styles-at-rules
at counterSytyles.css to be handled according to these
rules if counterStylesAtRules is enabled. Otherwise,
they are handled like before.

* LayoutTests/TestExpectations:
* LayoutTests/fast/lists/decimal-leading-zero-expected.txt:
* LayoutTests/fast/lists/decimal-leading-zero.html:
* Source/WebCore/css/CSSCounterStyle.cpp:
* Source/WebCore/css/CSSCounterStyle.h:
* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
(WebCore::isCounterStyleUnsupportedByUserAgent):
* Source/WebCore/css/CSSCounterStyleRegistry.h:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/counterStyles.css:
(@counter-style square):
(@counter-style cjk-earthly-branch):
(@counter-style cjk-heavenly-stem):
* Source/WebCore/editing/Editor.cpp:
(WebCore::editableTextListsAtPositionInDescendingOrder):
* Source/WebCore/editing/FontAttributes.h:
* Source/WebCore/editing/cocoa/FontAttributesCocoa.mm:
(WebCore::cocoaTextListMarkerName):
(WebCore::TextList::createTextList const):
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::textRun const):
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::updateContent):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::relativeMarkerRect):
(WebCore::RenderListMarker::counterStyle const):
(WebCore::RenderListMarker::widthUsesMetricsOfPrimaryFont const):
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/style/ListStyleType.cpp:
(WebCore::ListStyleType::isCircle const):
(WebCore::ListStyleType::isSquare const):
(WebCore::ListStyleType::isDisc const):
(WebCore::ListStyleType::isDisclosureClosed const):
* Source/WebCore/rendering/style/ListStyleType.h:
(WebCore::ListStyleType::operator== const):
(WebCore::ListStyleType::operator!= const):
(WebCore::ListStyleType::encode const):
(WebCore::ListStyleType::decode):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertListStyleType):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/261823@main




More information about the webkit-changes mailing list