[webkit-changes] [WebKit/WebKit] 6035f3: Build fix for "[Xcode] Fix size increase due to mu...

Elliott Williams noreply at github.com
Fri Mar 17 14:02:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6035f309d1f2f6975ffb08780ba64b30ff9b8d51
      https://github.com/WebKit/WebKit/commit/6035f309d1f2f6975ffb08780ba64b30ff9b8d51
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
    M Source/JavaScriptCore/Scripts/copy-profiling-data.sh
    M Source/WebCore/Configurations/WebCore.xcconfig
    M Source/WebKit/Configurations/BaseTarget.xcconfig

  Log Message:
  -----------
  Build fix for "[Xcode] Fix size increase due to multiple PGO profile support"
https://bugs.webkit.org/show_bug.cgi?id=254084
rdar://106867857

Unreviewed build fix.

Don't try to copy "Empty.profdata" in production builds where it is not
available. Even though copy-profiling-data.sh may now exit without
creating its output file, XCBuild will still incrementalize correctly
(my prior understanding about missing outputs was wrong).

Don't check for ENABLE_LLVM_PROFILE_GENERATION when defining
CLANG_OPTIMIZATION_PROFILE_FILE. This was breaking the setting's
expansion in the PGO builder, and is unnecesary.

Turn off CLANG_USE_OPTIMIZATION_PROFILE in open source builds.

* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
* Source/JavaScriptCore/Scripts/copy-profiling-data.sh:
* Source/WebCore/Configurations/WebCore.xcconfig:
* Source/WebKit/Configurations/BaseTarget.xcconfig:

Canonical link: https://commits.webkit.org/261807@main




More information about the webkit-changes mailing list