[webkit-changes] [WebKit/WebKit] 9e4639: [IFC][Ruby] Pass horizontal overhang values to IFC

Antti Koivisto noreply at github.com
Fri Mar 17 13:16:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e463964ffe8d9c5f2f1dbeee7a7fd31b3b51642
      https://github.com/WebKit/WebKit/commit/9e463964ffe8d9c5f2f1dbeee7a7fd31b3b51642
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.h
    M Source/WebCore/rendering/RenderRubyRun.cpp
    M Source/WebCore/rendering/RenderRubyRun.h

  Log Message:
  -----------
  [IFC][Ruby] Pass horizontal overhang values to IFC
https://bugs.webkit.org/show_bug.cgi?id=254068
rdar://106854905

Reviewed by Alan Baradlay.

* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp:
(WebCore::Layout::LineBox::logicalBorderBoxForAtomicInlineLevelBox const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:

Do a basic (non-dynamic, incorrect) overhang adjustment.

(WebCore::Layout::LineBuilder::inlineItemWidth const):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:

Add a define.

(WebCore::LayoutIntegration::canUseForChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):

Pass the overhang values.

* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::rubyAdjustments const):
(WebCore::Layout::Box::setRubyAdjustments):

Put ruby stuff into a struct.

(WebCore::Layout::Box::rubyAnnotationsAboveAndBelow const): Deleted.
(WebCore::Layout::Box::setRubyAnnotationsAboveAndBelow): Deleted.
* Source/WebCore/layout/layouttree/LayoutBox.h:
* Source/WebCore/rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang const):
(WebCore::RenderRubyRun::startAndEndOverhang const):

Factor computing static overhang values that don't depend on surrouding context into a function of their own.

* Source/WebCore/rendering/RenderRubyRun.h:

Canonical link: https://commits.webkit.org/261805@main




More information about the webkit-changes mailing list