[webkit-changes] [WebKit/WebKit] c6a5bc: [WebGPU] writeBuffer test is failing
mwyrzykowski
noreply at github.com
Fri Mar 17 12:05:57 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c6a5bcca33e3147a0aaa5ea1f3aa2384aae383da
https://github.com/WebKit/WebKit/commit/c6a5bcca33e3147a0aaa5ea1f3aa2384aae383da
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2023-03-17 (Fri, 17 Mar 2023)
Changed paths:
M LayoutTests/http/tests/webgpu/webgpu/api/operation/queue/writeBuffer-expected.txt
M LayoutTests/platform/mac/TestExpectations
M Source/WebCore/Modules/WebGPU/GPUQueue.cpp
M Source/WebCore/Modules/WebGPU/GPUQueue.h
M Source/WebGPU/WebGPU/Queue.h
M Source/WebGPU/WebGPU/Queue.mm
Log Message:
-----------
[WebGPU] writeBuffer test is failing
https://bugs.webkit.org/show_bug.cgi?id=253748
<radar://106583393>
Reviewed by Tadeu Zagallo.
Multiply offsets by the size of the element and fix race condition between
writeBuffer() and isIdle().
Also enable writeBuffer.html as it is passing but disable createSampler.html which
is a flaky 1-3% failure.
* LayoutTests/http/tests/webgpu/webgpu/api/operation/queue/writeBuffer-expected.txt:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::computeElementSize):
(WebCore::GPUQueue::writeBuffer):
* Source/WebCore/Modules/WebGPU/GPUQueue.h:
* Source/WebGPU/WebGPU/Queue.h:
(WebGPU::Queue::isIdle const): Deleted.
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::validateWriteBuffer const):
(WebGPU::Queue::writeBuffer):
(WebGPU::Queue::isIdle const):
(WebGPU::Queue::writeTexture):
Canonical link: https://commits.webkit.org/261802@main
More information about the webkit-changes
mailing list