[webkit-changes] [WebKit/WebKit] c12569: Remove credentials when data store is removed

Sihui noreply at github.com
Fri Mar 17 10:24:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c12569834190602fac4ec3373709335712b2110f
      https://github.com/WebKit/WebKit/commit/c12569834190602fac4ec3373709335712b2110f
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
    M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm

  Log Message:
  -----------
  Remove credentials when data store is removed
https://bugs.webkit.org/show_bug.cgi?id=253921
rdar://problem/106728064

Reviewed by Chris Dumez.

HTTP credentials of data store are stored via NSURLCredentialStorage (and they are not under data store directory), so
we need to removed them via NSURLCredentialStorage (deleting data store directory would not remove them).

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::removeDataStoreWithIdentifier):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/261798@main




More information about the webkit-changes mailing list