[webkit-changes] [WebKit/WebKit] bb518e: [git-webkit] Handle ssh protocol with user

Jonathan Bedard noreply at github.com
Fri Mar 17 09:02:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb518ed013066cabbbaf6ff2e49add3e0696945c
      https://github.com/WebKit/WebKit/commit/bb518ed013066cabbbaf6ff2e49add3e0696945c
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M Tools/Scripts/hooks/pre-push
    M Tools/Scripts/libraries/webkitscmpy/setup.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py
    A Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py

  Log Message:
  -----------
  [git-webkit] Handle ssh protocol with user
https://bugs.webkit.org/show_bug.cgi?id=254052
rdar://106832995

Reviewed by Aakash Jain.

A remote URL of the format 'ssh://git@...' is valid, but breaks our regex.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/hooks/pre-push: Use a regex defined by our template.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py:
(InstallHooks): Update REMOTE_RE to handle ssh protocol with user.
(InstallHooks.main): Pass REMOTE_RE to template.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py: Added.
(TestInstallHooks):
(TestInstallHooks.setUp):
(TestInstallHooks.test_regex):

Canonical link: https://commits.webkit.org/261795@main




More information about the webkit-changes mailing list