[webkit-changes] [WebKit/WebKit] 18e688: REGRESSION(261684 at main): [GStreamer] Crash in webk...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18e688d4e90d176d7b7d81e27752a458151d38ec
      https://github.com/WebKit/WebKit/commit/18e688d4e90d176d7b7d81e27752a458151d38ec
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

  Log Message:
  -----------
  REGRESSION(261684 at main): [GStreamer] Crash in webkit_media_stream_src_class_init() when logging into Google account
https://bugs.webkit.org/show_bug.cgi?id=254025

Reviewed by Xabier Rodriguez-Calvar.

Make sure that GStreamer is initialized before attempting to register the custom WebKit GStreamer
elements.

Drive-by change, move the MSE "decoding limits" just before it's used and remove mis-used and
superfluous ASSERT_NOT_REACHED.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::supportsType):
* Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):

Canonical link: https://commits.webkit.org/261786@main