[webkit-changes] [WebKit/WebKit] 04235c: Cherry-pick 261764 at main (0d4acd6a56aa). https://bu...

[Carlos Garcia Campos]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 04235ce7b0211fb041cd7ff26db3efcf4a920441
      https://github.com/WebKit/WebKit/commit/04235ce7b0211fb041cd7ff26db3efcf4a920441
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M Source/bmalloc/libpas/src/libpas/pas_bitvector.h

  Log Message:
  -----------
  Cherry-pick 261764 at main (0d4acd6a56aa). https://bugs.webkit.org/show_bug.cgi?id=254035

    Fix undefined behavior in pas_bitvector.h's PAS_BITVECTOR_BIT_MASK()
    https://bugs.webkit.org/show_bug.cgi?id=254035

    Reviewed by Yusuke Suzuki.

    Fix undefined behavior in pas_bitvector.h's PAS_BITVECTOR_BIT_MASK():
    /Volumes/Work/WebKit/OpenSource/Source/bmalloc/libpas/src/libpas/pas_bitvector.h:97:24: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior

    This was found by UBSan.

    * Source/bmalloc/libpas/src/libpas/pas_bitvector.h:

    Canonical link: https://commits.webkit.org/261764@main


  Commit: 82cc274317c20075e064af3b4a1de7cd4e17afbd
      https://github.com/WebKit/WebKit/commit/82cc274317c20075e064af3b4a1de7cd4e17afbd
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/cairo/CairoOperations.cpp
    M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp
    M Source/WebCore/platform/graphics/cairo/CairoUtilities.h

  Log Message:
  -----------
  Cherry-pick 261318 at main (b59118c2ad0b). https://bugs.webkit.org/show_bug.cgi?id=247628

    [GTK] Crash in WebCore::Cairo::drawGlyphs if threaded rendering is enabled
    https://bugs.webkit.org/show_bug.cgi?id=247628

    Reviewed by Žan Doberšek.

    We are now using a single rendering thread, but the main thread can
    still use FreeType during the recording phase while laying out text. So,
    we can try by using a global lock for FreeType.

    * Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:
    (WebCore::Cairo::drawGlyphs):
    * Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:
    (WebCore::cairoFontLock):
    * Source/WebCore/platform/graphics/cairo/CairoUtilities.h:
    (WebCore::CairoFtFaceLocker::CairoFtFaceLocker):
    (WebCore::CairoFtFaceLocker::~CairoFtFaceLocker):

    Canonical link: https://commits.webkit.org/261318@main


Compare: https://github.com/WebKit/WebKit/compare/2a5102da30b5...82cc274317c2