[webkit-changes] [WebKit/WebKit] bebe28: REGRESSION: GarageBand: Overlapping text displayed...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bebe288540737398e2d5db3779a585bf5645a3ff
      https://github.com/WebKit/WebKit/commit/bebe288540737398e2d5db3779a585bf5645a3ff
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    A LayoutTests/fast/inline/statically-positioned-out-of-inline-level-box-inside-inline-box-expected.html
    A LayoutTests/fast/inline/statically-positioned-out-of-inline-level-box-inside-inline-box.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp

  Log Message:
  -----------
  REGRESSION: GarageBand: Overlapping text displayed on the image icons in the guitar lesson list.
https://bugs.webkit.org/show_bug.cgi?id=254032
<rdar://106674763>

Reviewed by Antti Koivisto.

When the statically position out-of-flow inline-level box is inside and inline box
e.g.
 <span><img style="position: absolute"></span>
and has no direct _next_ sibling inside the inline box, the next sibling candidate for positioning this out-of-flow box is not the parent inline box but the parent inline box's next sibling (or parent parent as we climb out of nested inline boxes). This logic is slightly different from finding previous sibling, where the parent inline box is actually the candidate box.

* LayoutTests/fast/inline/statically-positioned-out-of-inline-level-box-inside-inline-box-expected.html: Added.
* LayoutTests/fast/inline/statically-positioned-out-of-inline-level-box-inside-inline-box.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::nextDisplayBoxIndex):

Canonical link: https://commits.webkit.org/261766@main