[webkit-changes] [WebKit/WebKit] c936c6: [UI-side compositing] Add lock for accessing NSScr...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c936c69128b0cb246f8faa4b7cbebd522c987dc1
      https://github.com/WebKit/WebKit/commit/c936c69128b0cb246f8faa4b7cbebd522c987dc1
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M Source/WebCore/page/scrolling/mac/ScrollerMac.mm
    M Source/WebCore/page/scrolling/mac/ScrollerPairMac.h
    M Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm

  Log Message:
  -----------
  [UI-side compositing] Add lock for accessing NSScrollerImpPair in ScrollerPairMac
https://bugs.webkit.org/show_bug.cgi?id=253984
rdar://106652775

Reviewed by Simon Fraser.

Add locks for use when accessing the NSScrollerImpPair on ScrollerPairMac since
NSScrollerImpPair is not thread safe.

* Source/WebCore/page/scrolling/mac/ScrollerMac.mm:
(WebCore::ScrollerMac::attach):
(WebCore::ScrollerMac::setHostLayer):
* Source/WebCore/page/scrolling/mac/ScrollerPairMac.h:
(WebCore::ScrollerPairMac::WTF_REQUIRES_LOCK):
(WebCore::ScrollerPairMac::WTF_RETURNS_LOCK):
(WebCore::ScrollerPairMac::scrollerImpPair): Deleted.
* Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm:
(WebCore::ScrollerPairMac::init):
(WebCore::ScrollerPairMac::~ScrollerPairMac):
(WebCore::ScrollerPairMac::handleWheelEventPhase):
(WebCore::ScrollerPairMac::handleMouseEvent):
(WebCore::ScrollerPairMac::updateValues):

Canonical link: https://commits.webkit.org/261759@main