[webkit-changes] [WebKit/WebKit] ade45d: REGRESSION: Bidi text gets wrongly wrapped when li...

Alan Baradlay noreply at github.com
Thu Mar 16 12:19:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ade45ddc4c8ebef32fdec8e086c243104947da21
      https://github.com/WebKit/WebKit/commit/ade45ddc4c8ebef32fdec8e086c243104947da21
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    A LayoutTests/fast/text/bidi-with-non-preserved-tab-expected.html
    A LayoutTests/fast/text/bidi-with-non-preserved-tab.html
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp

  Log Message:
  -----------
  REGRESSION: Bidi text gets wrongly wrapped when line-breaking
https://bugs.webkit.org/show_bug.cgi?id=254024
<rdar://105038980>

Reviewed by Antti Koivisto.

Non-preserved tab characters need the same special treatment as non-preserved line breaks (replace them with space characters).

* LayoutTests/fast/text/bidi-with-non-preserved-tab-expected.html: Added.
* LayoutTests/fast/text/bidi-with-non-preserved-tab.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::replaceNonPreservedNewLineAndTabCharactersAndAppend):
(WebCore::Layout::buildBidiParagraph):
(WebCore::Layout::replaceNonPreservedNewLineCharactersAndAppend): Deleted.

Canonical link: https://commits.webkit.org/261756@main




More information about the webkit-changes mailing list