[webkit-changes] [WebKit/WebKit] 1fe6b1: [JSC] Add ClassSetCharacter syntax tests for RegEx...

Michael Saboff noreply at github.com
Thu Mar 16 07:37:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fe6b1dc37f170c19e6483afc9be1e9ebca59fbf
      https://github.com/WebKit/WebKit/commit/1fe6b1dc37f170c19e6483afc9be1e9ebca59fbf
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M JSTests/stress/regexp-vflag-property-of-strings.js
    M Source/JavaScriptCore/yarr/YarrParser.h

  Log Message:
  -----------
  [JSC] Add ClassSetCharacter syntax tests for RegExp V flag and fix issues found
https://bugs.webkit.org/show_bug.cgi?id=254007
rdar://106789711

Reviewed by Mark Lam.

Added ClassCharacterSet tests.

Factored out the syntax checking of class set character from parseClassSet() to
consumeAndCheckIfValidClassSetCharacter() and used it in its original location as well as
parseClassStringDisjunction().  Added an additional check for the reserved double punctuators.
Also added explicit handling of '-' in parseClassStringDisjunction() since it is an
additional syntax error, where it is needed for constructing ranges in parseClassSet().

* JSTests/stress/regexp-vflag-property-of-strings.js:
* Source/JavaScriptCore/yarr/YarrParser.h:
(JSC::Yarr::Parser::consumeAndCheckIfValidClassSetCharacter):
(JSC::Yarr::Parser::parseClassSet):
(JSC::Yarr::Parser::parseClassStringDisjunction):

Canonical link: https://commits.webkit.org/261746@main




More information about the webkit-changes mailing list