[webkit-changes] [WebKit/WebKit] 320560: [GTK] Remove GLX support

Carlos Garcia Campos noreply at github.com
Thu Mar 16 05:20:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 320560f9e53ddcd53954059bd005e0c75eb91abf
      https://github.com/WebKit/WebKit/commit/320560f9e53ddcd53954059bd005e0c75eb91abf
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/PlatformGTK.cmake
    M Source/WebCore/PlatformWPE.cmake
    M Source/WebCore/SourcesGTK.txt
    M Source/WebCore/platform/graphics/GLContext.cpp
    M Source/WebCore/platform/graphics/GLContext.h
    M Source/WebCore/platform/graphics/PlatformDisplay.cpp
    M Source/WebCore/platform/graphics/PlatformDisplay.h
    R Source/WebCore/platform/graphics/glx/GLContextGLX.cpp
    R Source/WebCore/platform/graphics/glx/GLContextGLX.h
    M Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp
    M Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp
    M Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h
    R Source/WebCore/platform/graphics/x11/XUniquePtr.cpp
    M Source/WebCore/platform/graphics/x11/XUniquePtr.h
    M Source/WebCore/platform/graphics/x11/XUniqueResource.cpp
    M Source/WebCore/platform/graphics/x11/XUniqueResource.h
    M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp
    M Source/cmake/FindOpenGL.cmake
    M Source/cmake/OptionsGTK.cmake
    M Tools/Scripts/generate-bundle
    M Tools/Scripts/webkitpy/port/xvfbdriver.py
    M Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py

  Log Message:
  -----------
  [GTK] Remove GLX support
https://bugs.webkit.org/show_bug.cgi?id=254016

Reviewed by Žan Doberšek.

We are now using EGL also on X11, keeping the GLX implementation as a
fallback, that is likely unused.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/PlatformGTK.cmake:
* Source/WebCore/PlatformWPE.cmake:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/platform/graphics/GLContext.cpp:
(WebCore::GLContext::createContextForWindow):
(WebCore::GLContext::createSharingContext):
* Source/WebCore/platform/graphics/GLContext.h:
* Source/WebCore/platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::sharedDisplayDidClose):
* Source/WebCore/platform/graphics/PlatformDisplay.h:
* Source/WebCore/platform/graphics/glx/GLContextGLX.cpp: Removed.
* Source/WebCore/platform/graphics/glx/GLContextGLX.h: Removed.
* Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:
(createGstGLDisplay):
(PlatformDisplay::tryEnsureGstGLContext const):
* Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::PlatformDisplayX11):
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
(WebCore::clearSharingGLContextAtExit): Deleted.
(WebCore::PlatformDisplayX11::supportsGLX const): Deleted.
* Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h:
* Source/WebCore/platform/graphics/x11/XUniquePtr.cpp: Removed.
* Source/WebCore/platform/graphics/x11/XUniquePtr.h:
* Source/WebCore/platform/graphics/x11/XUniqueResource.cpp:
(WebCore::XUniqueResource<XResource::GLXPbuffer>::deleteXResource): Deleted.
(WebCore::XUniqueResource<XResource::GLXPixmap>::deleteXResource): Deleted.
* Source/WebCore/platform/graphics/x11/XUniqueResource.h:
* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::openGLAPI):
(WebKit::WebKitProtocolHandler::handleGPU):
* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:
(WebKit::AcceleratedBackingStoreX11::checkRequirements):
(WebKit::AcceleratedBackingStoreX11::~AcceleratedBackingStoreX11):
(WebKit::AcceleratedBackingStoreX11::update):
(WebKit::glxErrorCode): Deleted.
* Source/cmake/FindOpenGL.cmake:
* Source/cmake/OptionsGTK.cmake:
* Tools/Scripts/generate-bundle:
* Tools/Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._xvfb_run):
* Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.test_xvfb_start_and_ready):
(XvfbDriverTest.test_xvfb_start_arbitrary_worker_number):

Canonical link: https://commits.webkit.org/261741@main




More information about the webkit-changes mailing list