[webkit-changes] [WebKit/WebKit] f0e980: Cherry-pick 261497 at main (1c49120b32b3). https://bu...

mattwoodrow noreply at github.com
Thu Mar 16 03:03:37 PDT 2023


  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: f0e980d067678ecaa384856ff98945a595a22410
      https://github.com/WebKit/WebKit/commit/f0e980d067678ecaa384856ff98945a595a22410
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/interaction/focus/tabindex-focus-flag-expected.txt
    M Source/WebCore/html/HTMLSummaryElement.cpp

  Log Message:
  -----------
  Cherry-pick 261497 at main (1c49120b32b3). https://bugs.webkit.org/show_bug.cgi?id=253680

    Summary element is not focusable with tabindex

    https://bugs.webkit.org/show_bug.cgi?id=253680

    Reviewed by Aditya Keerthi.

    This patch aligns WebKit to Gecko / Firefox and Blink / Chromium by adding 'HTMLElement::supportsFocus'
    similar to other elements to enable 'summary' element being focusable with tabindex on element.

    * Source/WebKit/html/HTMLSummaryElement.cpp:
    (HTMLSummaryElement::supportsFocus):
    * LayoutTests/imported/w3c/web-platform-tests/html/interaction/focus/tabindex-focus-flag-expected.txt: Rebaselined

    Canonical link: https://commits.webkit.org/261497@main


  Commit: 6c7e649770e8a31b40e4e78fd962ca3b06b086b8
      https://github.com/WebKit/WebKit/commit/6c7e649770e8a31b40e4e78fd962ca3b06b086b8
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/dom/nodes/adoption.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-content-hierarcy-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/template-expected.txt
    M Source/WebCore/dom/ContainerNode.cpp
    M Source/WebCore/dom/Document.cpp

  Log Message:
  -----------
  Cherry-pick 261491 at main (dd0a5a2fd2e2). https://bugs.webkit.org/show_bug.cgi?id=246899

    document.adoptNode is a no-op when called on a template element's document fragment
    https://bugs.webkit.org/show_bug.cgi?id=246899

    Reviewed by Chris Dumez.

    Partially revert 252098 at main as this change turned out to be not web compatible.

    * LayoutTests/imported/w3c/web-platform-tests/dom/nodes/adoption.window-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-content-hierarcy-expected.txt:
    * LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/template-expected.txt:
    * Source/WebCore/dom/ContainerNode.cpp:
    (WebCore::containsIncludingHostElements):
    * Source/WebCore/dom/Document.cpp:
    (WebCore::Document::adoptNode):

    Canonical link: https://commits.webkit.org/261491@main


  Commit: 4965e79612f1028f1e1ff254aece31e55274293c
      https://github.com/WebKit/WebKit/commit/4965e79612f1028f1e1ff254aece31e55274293c
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M Source/WebCore/dom/StyledElement.cpp

  Log Message:
  -----------
  Cherry-pick 261490 at main (0a5a6b015b9f). https://bugs.webkit.org/show_bug.cgi?id=253694

    Temporary workaround attempt for Production build crashes
    https://bugs.webkit.org/show_bug.cgi?id=253694
    rdar://106522324

    Unreviewed, land a temporary workaround that seems to prevent the production
    builds from crashing locally.

    I was able to reproduce the crashes by enabling ThinLTO. This seemingly
    equivalent code made the crashes go away for me so I am landing it to get
    the perf bots hopefully running again.

    * Source/WebCore/dom/StyledElement.cpp:
    (WebCore::StyledElement::setInlineStyleProperty):

    Canonical link: https://commits.webkit.org/261490@main


  Commit: e7bcb8fe03f36c4aa3298d340b7bcf088c60f6e5
      https://github.com/WebKit/WebKit/commit/e7bcb8fe03f36c4aa3298d340b7bcf088c60f6e5
  Author: Diego Pino Garcia <dpino at igalia.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  Cherry-pick 261480 at main (45c0db167f82). https://bugs.webkit.org/show_bug.cgi?id=253530

    [GCC] Unreviewed, build fix for Ubuntu 20.04 after 261358 at main
    https://bugs.webkit.org/show_bug.cgi?id=253530

    GCC9 requires explicit defition of operator!=.

    * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
    (JSC::Wasm::BBQJIT::Location::operator!= const):

    Canonical link: https://commits.webkit.org/261480@main


  Commit: fe6c1dfc97ec3e4eca2ee1b57cc41fd8aafde813
      https://github.com/WebKit/WebKit/commit/fe6c1dfc97ec3e4eca2ee1b57cc41fd8aafde813
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M Source/WebCore/html/HTMLCanvasElement.cpp
    M Source/WebCore/html/HTMLCanvasElement.h
    M Source/WebCore/platform/graphics/GraphicsLayer.cpp
    M Source/WebCore/platform/graphics/GraphicsLayer.h
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
    M Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h
    M Source/WebCore/rendering/RenderHTMLCanvas.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm

  Log Message:
  -----------
  Cherry-pick 261484 at main (876cd0f5d213). https://bugs.webkit.org/show_bug.cgi?id=253614

    Use the Copy CompositeOperator when copying canvas into its layer.
    https://bugs.webkit.org/show_bug.cgi?id=253614

    Reviewed by Simon Fraser.

    When the canvas buffer is the only draw into the layer, we should be able to just directly copy the pixels instead of blending.
    This also means we can skip clearing the back buffer.

    * Source/WebCore/html/HTMLCanvasElement.cpp:
    (WebCore::HTMLCanvasElement::paint):
    * Source/WebCore/html/HTMLCanvasElement.h:
    * Source/WebCore/platform/graphics/GraphicsLayer.cpp:
    (WebCore::GraphicsLayer::GraphicsLayer):
    * Source/WebCore/platform/graphics/GraphicsLayer.h:
    (WebCore::GraphicsLayer::paintUsingCompositeCopy const):
    (WebCore::GraphicsLayer::setPaintUsingCompositeCopy):
    (WebCore::GraphicsLayer::canCopy const): Deleted.
    (WebCore::GraphicsLayer::setCanCopy): Deleted.
    * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
    * Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h:
    (WebCore::PlatformCALayerClient::platformCALayerPaintUsingCompositeCopy const):
    (WebCore::PlatformCALayerClient::platformCALayerCanCopy const): Deleted.
    * Source/WebCore/rendering/RenderHTMLCanvas.cpp:
    (WebCore::RenderHTMLCanvas::paintReplaced):
    * Source/WebCore/rendering/RenderLayer.cpp:
    (WebCore::RenderLayer::RenderLayer):
    * Source/WebCore/rendering/RenderLayer.h:
    (WebCore::RenderLayer::paintUsingCompositeCopy const):
    (WebCore::RenderLayer::setPaintUsingCompositeCopy):
    (WebCore::RenderLayer::canCopy const): Deleted.
    (WebCore::RenderLayer::setCanCopy): Deleted.
    * Source/WebCore/rendering/RenderLayerBacking.cpp:
    (WebCore::RenderLayerBacking::updateConfiguration):
    * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
    (WebKit::RemoteLayerBackingStore::drawInContext):

    Canonical link: https://commits.webkit.org/261484@main


Compare: https://github.com/WebKit/WebKit/compare/352a0cdf56fb...fe6c1dfc97ec


More information about the webkit-changes mailing list