[webkit-changes] [WebKit/WebKit] 8c4340: Cherry-pick 261724 at main (ee58c2ab8371). https://bu...

[Przemyslaw Gorszkowski]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c4340e5ae942c99eeb2ae3db184c1d6a864158e
      https://github.com/WebKit/WebKit/commit/8c4340e5ae942c99eeb2ae3db184c1d6a864158e
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M Source/WebCore/Modules/speech/SpeechRecognition.cpp
    M Source/WebCore/Modules/speech/SpeechRecognition.h
    M Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h

  Log Message:
  -----------
  Cherry-pick 261724 at main (ee58c2ab8371). https://bugs.webkit.org/show_bug.cgi?id=249368

    REGRESSION(257515 at main): breaks build with -flto=auto
    https://bugs.webkit.org/show_bug.cgi?id=249368

    Reviewed by Philippe Normand.

    Workaround compiler/linker issue with LTO enabled with certain versions
    of GCC and Binutils on Linux. Tested using a Yocto build targeting
    AArch64 (Raspberry Pi 4), with LTO enabled, which uses GCC 11.3.0 and
    Binutils 2.38.

    * Source/WebCore/Modules/speech/SpeechRecognition.cpp:
    (WebCore::SpeechRecognition::~SpeechRecognition): Define an empty
    virtual destructor.
    * Source/WebCore/Modules/speech/SpeechRecognition.h: Declare a virtual
    destructor for the class.
    * Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h:
    (WebCore::SpeechRecognitionConnectionClient::~SpeechRecognitionConnectionClient):
    Once the complaint about the missing SpeechRecognition vtable was fixed,
    the linker started complaning about a missing virtual destructor for
    SpeechRecognitionConnectionClient, which is definitely a compiler bug
    given that it was defaulted; but using an empty inline destructor in the
    header workarounds the issue.

    Canonical link: https://commits.webkit.org/261724@main


  Commit: cbe361695f6ae973012ca394f24695911434f53f
      https://github.com/WebKit/WebKit/commit/cbe361695f6ae973012ca394f24695911434f53f
  Author: Przemyslaw Gorszkowski <pgorszkowski at igalia.com>
  Date:   2023-03-16 (Thu, 16 Mar 2023)

  Changed paths:
    M Tools/PlatformWPE.cmake

  Log Message:
  -----------
  Cherry-pick 261704 at main (c60dcc765e3b). https://bugs.webkit.org/show_bug.cgi?id=253962

    [WPE] Checkout newer version of COG
    https://bugs.webkit.org/show_bug.cgi?id=253962

    Reviewed by Adrian Perez de Castro.

    Checkout the newer version of COG from the current
    master tip which is: 48347f3a36e6dba75bcfd4f9443730861adec5b0

    This fix includes also replacing meson option 'soup2' with 'wpe_api'
    because of changes in COG.

    * Tools/PlatformWPE.cmake:

    Canonical link: https://commits.webkit.org/261704@main


Compare: https://github.com/WebKit/WebKit/compare/caf42ac47bf4...cbe361695f6a