[webkit-changes] [WebKit/WebKit] 0868fb: Turn Webcore::ReasonForDismissingAlternativeText i...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0868fb8dae10ba5c9e38ac61edffdf0724280223
      https://github.com/WebKit/WebKit/commit/0868fb8dae10ba5c9e38ac61edffdf0724280223
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Source/WebCore/editing/AlternativeTextController.cpp
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/page/AlternativeTextClient.h
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Scripts/webkit/messages.py
    A Source/WebKit/Shared/AlternativeTextClient.serialization.in
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/mac/CorrectionPanel.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp
    M Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.mm

  Log Message:
  -----------
  Turn Webcore::ReasonForDismissingAlternativeText into an 8-bit enum class
https://bugs.webkit.org/show_bug.cgi?id=253977
rdar://106729679

Reviewed by Tim Horton.

Refactor `ReasonForDismissingAlternativeText`, so that it's an enum class with an explicit width.
Instead of adding boilerplate `EnumTraits` support, we also use the newer `*.serialization.in`
mechanism to add support for IPC encoding and decoding.

* Source/WebCore/editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::~AlternativeTextController):
(WebCore::AlternativeTextController::stopPendingCorrection):
(WebCore::AlternativeTextController::applyPendingCorrection):
(WebCore::AlternativeTextController::handleCancelOperation):
(WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::AlternativeTextController::respondToAppliedEditing):
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::dismissCorrectionPanelAsIgnored):
* Source/WebCore/page/AlternativeTextClient.h:
(): Deleted.
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/AlternativeTextClient.serialization.in: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dismissCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanelSoon):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:

Instead of passing around raw `int32_t` values and casting to enum types on the destination, change
this to pass around enum types instead and use IPC serializers/deserializers.

* Source/WebKit/UIProcess/mac/CorrectionPanel.mm:
(WebKit::CorrectionPanel::CorrectionPanel):
(WebKit::CorrectionPanel::~CorrectionPanel):
(WebKit::CorrectionPanel::show):
(WebKit::CorrectionPanel::handleAcceptedReplacement):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::dismissContentRelativeChildWindowsFromViewOnly):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:
(WebKit::WebAlternativeTextClient::~WebAlternativeTextClient):
(WebKit::WebAlternativeTextClient::recordAutocorrectionResponse):
* Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.mm:
(CorrectionPanel::CorrectionPanel):
(CorrectionPanel::~CorrectionPanel):
(CorrectionPanel::show):
(CorrectionPanel::handleAcceptedReplacement):
* Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.mm:
(WebAlternativeTextClient::~WebAlternativeTextClient):

Canonical link: https://commits.webkit.org/261730@main