[webkit-changes] [WebKit/WebKit] 7bdf3c: Cherry-pick 260873 at main (f9e2e16a6e8d). https://bu...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 7bdf3cd486cd542a362ad2ee744564b7533fd6cf
      https://github.com/WebKit/WebKit/commit/7bdf3cd486cd542a362ad2ee744564b7533fd6cf
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.h

  Log Message:
  -----------
  Cherry-pick 260873 at main (f9e2e16a6e8d). https://bugs.webkit.org/show_bug.cgi?id=252815

    [GStreamer][MediaStream] Unify stream collection handling with MSE
    https://bugs.webkit.org/show_bug.cgi?id=252815

    Reviewed by Xabier Rodriguez-Calvar.

    Both the MSE and mediastream source elements now post their stream collection in a similar fashion.
    The custom mediastream tags handling was removed too, I don't know why that was needed in the first
    place.

    * LayoutTests/platform/glib/TestExpectations:
    * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
    (WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):
    (WebCore::MediaPlayerPrivateGStreamer::naturalSize const):
    (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
    * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
    (mediaStreamTrackPrivateGetTags):
    (webkitMediaStreamNew):
    (WebKitMediaStreamObserver::didRemoveTrack):
    (webkitMediaStreamSrcChangeState):
    (webkitMediaStreamSrcChain):
    (webkitMediaStreamSrcPostStreamCollection):
    (webkitMediaStreamSrcEnsureStreamCollectionPosted):
    (webkitMediaStreamSrcAddTrack):
    (webkitMediaStreamSrcSetStream):
    * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.h:

    Canonical link: https://commits.webkit.org/260873@main


  Commit: e27e1ca73de59af4cba7f37f0247604d27baacc4
      https://github.com/WebKit/WebKit/commit/e27e1ca73de59af4cba7f37f0247604d27baacc4
  Author: Alicia Boya Garcia <aboya at igalia.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
    M Source/WebCore/Modules/mediasource/SourceBuffer.h

  Log Message:
  -----------
  Cherry-pick 260876 at main (2c65a39b4fd6). https://bugs.webkit.org/show_bug.cgi?id=252894

    [MSE] Make input argument to canPlayThroughRange() const
    https://bugs.webkit.org/show_bug.cgi?id=252894
    Reviewed by Xabier Rodriguez-Calvar.

    Arguments passed by reference without const are generally
    assumed to be output arguments. This is not the case here.

    This patch fixes it.

    * Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
    (WebCore::SourceBuffer::canPlayThroughRange):
    * Source/WebCore/Modules/mediasource/SourceBuffer.h:

    Canonical link: https://commits.webkit.org/260876@main


  Commit: 3d95f610b82bc88d10f945a8a2504d2d5d27b8f4
      https://github.com/WebKit/WebKit/commit/3d95f610b82bc88d10f945a8a2504d2d5d27b8f4
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp

  Log Message:
  -----------
  Cherry-pick 260930 at main (b8d0c8eb86b0). https://bugs.webkit.org/show_bug.cgi?id=252980

    [GStreamer][WebRTC] Support for the new add-ice-candidate-full webrtcbin signal
    https://bugs.webkit.org/show_bug.cgi?id=252980

    Reviewed by Xabier Rodriguez-Calvar.

    By using this new signal we can avoid duplicate parsing of the ICE candidate string and potential
    racy behaviors when reporting errors back to the PeerConnectionBackend.

    * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
    (WebCore::GStreamerMediaEndpoint::addIceCandidate):
    * Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:
    (WebCore::parseIceCandidateSDP):

    Canonical link: https://commits.webkit.org/260930@main


  Commit: d02e20c60ae27266c8e304fa57eb3a6cb50d1212
      https://github.com/WebKit/WebKit/commit/d02e20c60ae27266c8e304fa57eb3a6cb50d1212
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp

  Log Message:
  -----------
  Cherry-pick 260996 at main (d6668df3100e). https://bugs.webkit.org/show_bug.cgi?id=251146

    [GStreamer][1.22] webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive.html crashing
    https://bugs.webkit.org/show_bug.cgi?id=251146

    Reviewed by Xabier Rodriguez-Calvar.

    The crash was due to webrtcbin detecting an invalid SDP message, containing 2 RTP direction
    attributes instead of one. So we now remove attributes unrelated with codec preferences, potentially
    leading to internal webrtcbin confusions such as duplicated RTP direction attributes for instance.

    * LayoutTests/platform/glib/TestExpectations:
    * Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp:
    (WebCore::GStreamerRtpTransceiverBackend::setDirection):
    * Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:
    (WebCore::capsFromSDPMedia):

    Canonical link: https://commits.webkit.org/260996@main


Compare: https://github.com/WebKit/WebKit/compare/d684893e771a...d02e20c60ae2