[webkit-changes] [WebKit/WebKit] 4bf80e: [GTK][WPE] run-webkit-tests: Add an option to enab...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4bf80e3962bbca2ce56edcf2b177d3b9e0326d23
      https://github.com/WebKit/WebKit/commit/4bf80e3962bbca2ce56edcf2b177d3b9e0326d23
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Tools/CISupport/build-webkit-org/steps.py
    M Tools/CISupport/build-webkit-org/steps_unittest.py
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py
    M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

  Log Message:
  -----------
  [GTK][WPE] run-webkit-tests: Add an option to enable coredumps and selectively enable it on the bots.
https://bugs.webkit.org/show_bug.cgi?id=253913

Reviewed by Carlos Garcia Campos.

This adds a new option to the script run-webkit-tests that if enabled
will run the equivalent of "ulimit -c unlimited" before starting the tests.
Therefore enabling core dumps for the test run.

Then, for the GTK and WPE ports, enable this flag when running layout tests
on the post-commit bots and on the EWS enable it on all the steps except in
the two ones that repeat the failures 11 times (with patch and without it).
This allows to disable repeatedly generating lot of coredumps (and backtraces)
when a test crashes.

This will allow the bots to finish much faster when there are crashes and will
help to avoid generating too much core dumps very fast which can fill the disk.

Generating this core dumps and backtraces is not useful on the repeat steps, as
those should be already generated on the standard steps (no need to repeat it).

* Tools/CISupport/build-webkit-org/steps.py:
(RunWebKitTests.start):
* Tools/CISupport/build-webkit-org/steps_unittest.py:
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.setLayoutTestCommand):
(RunWebKitTestsRepeatFailuresRedTree.setLayoutTestCommand):
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree.setLayoutTestCommand):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestRunWebKitTestsRedTree.test_success):
(TestRunWebKitTestsRedTree.test_set_properties_when_executed_scope_this_class):
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(run):

Canonical link: https://commits.webkit.org/261707@main