[webkit-changes] [WebKit/WebKit] fa4a52: Add OSXChromiumDriver and support extra browser ar...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa4a5245bfbbbbd12c6fd9fea70b4efc83f2023a
      https://github.com/WebKit/WebKit/commit/fa4a5245bfbbbbd12c6fd9fea70b4efc83f2023a
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
    M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py
    M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py

  Log Message:
  -----------
  Add OSXChromiumDriver and support extra browser arguments in run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=253553
rdar://106389711

Reviewed by Stephanie Lewis.

Support running benchmarks against Chromium in run-benchmark. Chromium
is like Chrome, except that it doesn't use the
--enable-field-trial-config switch, because field trials are enabled by
default.

Additionally, allow extra arguments to be passed to the browser process
through run-benchmark, to facilitate customized testing.

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromiumDriver): Added.

* Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(config_argument_parser): Add benchmark_args argument.

Remaining changes are all plumbing benchmark_args through to the browser
driver.

* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver.__init__):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
(BrowserDriverFactory.create):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver._launch_process):
(run_benchmark_plan):
* Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner.__init__):
* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
(BrowserPerfDashRunnerTest.test_can_construct_runner_object_minimum_parameters):
(FakeBrowserDriver.__init__):

Canonical link: https://commits.webkit.org/261697@main