[webkit-changes] [WebKit/WebKit] 424980: NSUUID with UUID::deletedValue is converted to a r...

Sihui noreply at github.com
Wed Mar 15 00:38:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 424980e4bed28f494a3635d9c17e38ef8b0bd9cc
      https://github.com/WebKit/WebKit/commit/424980e4bed28f494a3635d9c17e38ef8b0bd9cc
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-03-15 (Wed, 15 Mar 2023)

  Changed paths:
    M Source/WTF/wtf/UUID.cpp
    M Source/WTF/wtf/UUID.h
    M Source/WTF/wtf/cocoa/UUIDCocoa.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WTF/cocoa/UUIDCocoa.mm

  Log Message:
  -----------
  NSUUID with UUID::deletedValue is converted to a random WTF::UUID
https://bugs.webkit.org/show_bug.cgi?id=253805
rdar://106626402

Reviewed by Geoffrey Garen.

Add a new static function UUID::fromNSUUID to replace UUID(NSUUID *), which would return std::nullopt if NSUUID contains
UUID::deleteValue.

* Source/WTF/wtf/UUID.cpp:
(WTF::UUID::parse):
* Source/WTF/wtf/UUID.h:
* Source/WTF/wtf/cocoa/UUIDCocoa.mm:
(WTF::UUID::fromNSUUID):
(WTF::UUID::UUID): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore dataStoreForIdentifier:]):
(+[WKWebsiteDataStore _removeDataStoreWithIdentifier:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm:
(+[_WKWebExtensionControllerConfiguration configurationWithIdentifier:]):
(-[_WKWebExtensionControllerConfiguration initWithCoder:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration initWithIdentifier:]):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WTF/cocoa/UUIDCocoa.mm: Copied from Source/WTF/wtf/cocoa/UUIDCocoa.mm.
(TEST):

Canonical link: https://commits.webkit.org/261677@main




More information about the webkit-changes mailing list