[webkit-changes] [WebKit/WebKit] 2d0106: Correct RenderListMarker::styleDidChange check for...

Tim Nguyen noreply at github.com
Tue Mar 14 22:38:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d0106d057af3e75c627de59acbb5fc421377eb6
      https://github.com/WebKit/WebKit/commit/2d0106d057af3e75c627de59acbb5fc421377eb6
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderListMarker.cpp

  Log Message:
  -----------
  Correct RenderListMarker::styleDidChange check for list-style-type after 261651 at main
https://bugs.webkit.org/show_bug.cgi?id=253933
rdar://106737094

Reviewed by Antti Koivisto.

The new check in 261651 at main is incorrect, we can simply remove the `style().listStyleType().type == ListStyleType::Type::String` part.

The `style().listStyleType() != oldStyle->listStyleType()` now covers the string case too, since ListStyleType's equality operator checks both the identifier and the type.

* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::styleDidChange):

Canonical link: https://commits.webkit.org/261675@main




More information about the webkit-changes mailing list