[webkit-changes] [WebKit/WebKit] d0509c: Improve attachment wide-layout display

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0509c40b6a5d54a51c30b85c72cda34efda4077
      https://github.com/WebKit/WebKit/commit/d0509c40b6a5d54a51c30b85c72cda34efda4077
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/HTMLAttachmentElement.h
    M Source/WebCore/html/shadow/attachmentElementShadow.css
    M Source/WebCore/rendering/AttachmentLayout.mm
    M Source/WebCore/rendering/RenderThemeMac.mm

  Log Message:
  -----------
  Improve attachment wide-layout display
https://bugs.webkit.org/show_bug.cgi?id=253687
rdar://problem/106534843

Reviewed by Aditya Keerthi.

Some work towards the target vspecs:
- More complex shadow DOM tree that mirrors the specs.
- macOS rendering displays just an icon, with the new size.
- Better handling of long labels.

* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::attachmentPreviewAreaIdentifier):
(WebCore::attachmentInformationAreaIdentifier):
(WebCore::attachmentInformationBlockIdentifier):
(WebCore::attachmentSaveAreaIdentifier):
(WebCore::attachmentSaveIconIdentifier):
(WebCore::createContainedElement):
(WebCore::HTMLAttachmentElement::ensureModernShadowTree):
(WebCore::HTMLAttachmentElement::updateSaveButton):
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-container):
(div#attachment-preview-area):
(attachment#attachment-preview):
(div#attachment-information-area):
(div#attachment-information-block):
(div#attachment-action):
(div#attachment-title):
(div#attachment-subtitle):
(div#attachment-save-area):
(button#attachment-save-button):
(div#attachment-save-icon):
* Source/WebCore/rendering/AttachmentLayout.mm:
(WebCore::AttachmentLayout::AttachmentLayout):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintAttachment):

Canonical link: https://commits.webkit.org/261665@main