[webkit-changes] [WebKit/WebKit] 4dab8f: Cherry-pick 260794 at main (61138013faef). https://bu...

[Enrique Ocaña González]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dab8f2b1f487c693633de97b6b2d05c98a2b39b
      https://github.com/WebKit/WebKit/commit/4dab8f2b1f487c693633de97b6b2d05c98a2b39b
  Author: Enrique Ocaña González <eocanha at igalia.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

  Log Message:
  -----------
  Cherry-pick 260794 at main (61138013faef). https://bugs.webkit.org/show_bug.cgi?id=252480

    [GStreamer][MSE] Reinstall matroskademuxForceSegmentStartToEqualZero probe on relinking
    https://bugs.webkit.org/show_bug.cgi?id=252480

    When a matroskademux src pad is relinked (because the old one was removed), the
    probe that corrects the segment start is lost with the disappearing pad and
    never reinstalled on the replacing one. This can cause issues, for instance,
    while doing trick playback in reverse on Broadcom devices, which don't need
    parsers.

    During trickplay, pads between demux and appsink elements are relinked.
    GstBuffers related to trick playback are rejected/clipped by appsink (more
    precisely, by its base class: GstBaseSink), because GstSegment start position
    value don't match to those GstBuffers.

    See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1033

    Co-authored by: Jacek Skiba <jacek.skiba at consult.red>

    Reviewed by Alicia Boya Garcia.

    * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
    (WebCore::AppendPipeline::recycleTrackForPad): Reinstall the probe.

    Canonical link: https://commits.webkit.org/260794@main