[webkit-changes] [WebKit/WebKit] 158c78: [CMake][Win] builtins_generate_combined_header.py ...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 158c7837fac49713b8e31a8fae3b8db3f121ad9b
      https://github.com/WebKit/WebKit/commit/158c7837fac49713b8e31a8fae3b8db3f121ad9b
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/CMakeLists.txt

  Log Message:
  -----------
  [CMake][Win] builtins_generate_combined_header.py is generated twice both in JavaScriptCoreSharedScripts.vcxproj and JSCBuiltins.vcxproj
https://bugs.webkit.org/show_bug.cgi?id=253876

Reviewed by Don Olmstead.

In CMake Visual Studio generator builds, JavaScriptCore scripts were
copied twice both in JavaScriptCoreSharedScripts.vcxproj and
JSCBuiltins.vcxproj.

The fundamental problem of this bug was fixed in CMake v3.12.
<https://gitlab.kitware.com/cmake/cmake/-/commit/5a6c6292898fe238f3a5105133b8904209fbedaf>

JavaScriptCoreSharedScripts and JSCBuiltins targets need to have a
direct or indirect dependency for CMake Visual Studio generator to
eliminate duplicated custom commands. Otherwise, JavaScriptCore
scripts will be generated in both projects.

* Source/JavaScriptCore/CMakeLists.txt:

Canonical link: https://commits.webkit.org/261645@main