[webkit-changes] [WebKit/WebKit] 167838: AX: Add support for "code" ARIA role

Tyler Wilcock noreply at github.com
Tue Mar 14 11:02:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1678385b2d59405274a6499f5c8a1b11289541b6
      https://github.com/WebKit/WebKit/commit/1678385b2d59405274a6499f5c8a1b11289541b6
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
    M LayoutTests/accessibility/display-contents-element-roles-expected.txt
    M LayoutTests/accessibility/roles-computedRoleString.html
    M LayoutTests/platform/glib/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/glib/accessibility/display-contents-element-roles-expected.txt
    M LayoutTests/platform/ios/accessibility/display-contents-element-roles-expected.txt
    M LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
    M LayoutTests/platform/wpe/accessibility/aria-visible-element-roles-expected.txt
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
    M Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm

  Log Message:
  -----------
  AX: Add support for "code" ARIA role
https://bugs.webkit.org/show_bug.cgi?id=253799
rdar://problem/106621574

Reviewed by Chris Fleizach.

As defined here:

https://w3c.github.io/core-aam/#role-map-code

Prior to this patch we already handled the `code` element, so this
patch overloads any meaningful usage of that to also include role="code"
elements.

* LayoutTests/accessibility/display-contents-element-roles-expected.txt:
* LayoutTests/accessibility/roles-computedRoleString.html:
* LayoutTests/platform/glib/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/glib/accessibility/display-contents-element-roles-expected.txt:
* LayoutTests/platform/ios/accessibility/display-contents-element-roles-expected.txt:
* LayoutTests/platform/wpe/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt:
Update test expectations.

* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::initializeRoleMap):
(WebCore::AccessibilityObject::isStyleFormatGroup const):
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::accessibilityRoleToString):
(WebCore::AXCoreObject::isCode const):
* Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::attributeStringSetStyle):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper accessibilityTextualContext]):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::subrolePlatformString const):
(WebCore::Accessibility::createPlatformRoleMap):
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:

Canonical link: https://commits.webkit.org/261640@main




More information about the webkit-changes mailing list