[webkit-changes] [WebKit/WebKit] 91848d: REGRESSION(261586 at main): The assertion is randomly...
Chris Dumez
noreply at github.com
Tue Mar 14 09:22:05 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 91848d64a7b3023c09a617e85b133c0a57c41008
https://github.com/WebKit/WebKit/commit/91848d64a7b3023c09a617e85b133c0a57c41008
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-03-14 (Tue, 14 Mar 2023)
Changed paths:
M Source/WebCore/dom/Document.cpp
Log Message:
-----------
REGRESSION(261586 at main): The assertion is randomly failing
https://bugs.webkit.org/show_bug.cgi?id=253875
rdar://106705387
Unreviewed, drop assertion in ~Document() to make sure that m_ranges is empty
as it is hitting on the bots since we updated m_ranges to be a WeakHashSet.
Ranges no longer remove themselves in their destructor from this set so this
assertion is no longer guaranteed to hold. The WeakHashSet will empty itself
as Range objects get destroyed but ~Document() may get called while the
destructor of a Range is still running.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::~Document):
Canonical link: https://commits.webkit.org/261634@main
More information about the webkit-changes
mailing list