[webkit-changes] [WebKit/WebKit] e33478: [JSC] Fix Wasm dumpDisassembly configurations

Yusuke Suzuki noreply at github.com
Mon Mar 13 19:17:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e334781d41142d6fb37272b37a06769e7e8e145f
      https://github.com/WebKit/WebKit/commit/e334781d41142d6fb37272b37a06769e7e8e145f
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
    M Source/JavaScriptCore/wasm/WasmBBQPlan.h
    M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp
    M Source/JavaScriptCore/wasm/WasmOMGPlan.h
    M Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp
    M Source/JavaScriptCore/wasm/WasmOSREntryPlan.h

  Log Message:
  -----------
  [JSC] Fix Wasm dumpDisassembly configurations
https://bugs.webkit.org/show_bug.cgi?id=253862
rdar://problem/106675530

Reviewed by Justin Michaud.

This patch cleans up and fixes wasm dumpDisassembly configuration issues.

1. Make dumpBBQDisassembly work. Previously, it was broken for new WasmBBQJIT.
   Remove many hacks for useSinglePassBBQJIT.
2. Clean up condition code for dumpDisassembly.

* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::dumpDisassembly):
(JSC::Wasm::BBQPlan::work):
(JSC::Wasm::BBQPlan::didCompleteCompilation):
* Source/JavaScriptCore/wasm/WasmBBQPlan.h:
* Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::dumpDisassembly):
(JSC::Wasm::OMGPlan::work):
* Source/JavaScriptCore/wasm/WasmOMGPlan.h:
* Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp:
(JSC::Wasm::OSREntryPlan::dumpDisassembly):
(JSC::Wasm::OSREntryPlan::work):
* Source/JavaScriptCore/wasm/WasmOSREntryPlan.h:

Canonical link: https://commits.webkit.org/261610@main




More information about the webkit-changes mailing list