[webkit-changes] [WebKit/WebKit] 1dc774: REGRESSION (macOS 13.3 Beta): WKWebView doesn't sc...
Richard Robinson
noreply at github.com
Mon Mar 13 14:24:37 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1dc77463aa2354aeac5ae0a071a9f50627e6e68d
https://github.com/WebKit/WebKit/commit/1dc77463aa2354aeac5ae0a071a9f50627e6e68d
Author: Richard Robinson <richard_robinson2 at apple.com>
Date: 2023-03-13 (Mon, 13 Mar 2023)
Changed paths:
M Source/WebCore/editing/EditorCommand.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
Log Message:
-----------
REGRESSION (macOS 13.3 Beta): WKWebView doesn't scroll in response to NSResponder.scrollPageDown(_:)
https://bugs.webkit.org/show_bug.cgi?id=253785
rdar://106201169
Reviewed by Simon Fraser.
259146 at main caused this regression since it directly removed these selectors and their
corresponding functions. They were removed so that the new key-repeat behavior was consistent
between Page Up/Down and the space bar.
This PR fixes this by reverting the part of 259146 at main that altered these functions to restore
their original behavior, while also maintaining the consistency of the key-repeat behavior that 259146 at main implemented.
* Source/WebCore/editing/EditorCommand.cpp:
(WebCore::executeScrollPageBackward):
(WebCore::executeScrollPageForward):
(WebCore::createCommandMap):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::defaultPageUpDownEventHandler):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::selectorExceptionMap):
Canonical link: https://commits.webkit.org/261589@main
More information about the webkit-changes
mailing list