[webkit-changes] [WebKit/WebKit] c5cfff: [GStreamer] Try to detect and recover inconsistent...

Xabier Rodríguez noreply at github.com
Mon Mar 13 07:32:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5cfffe19659bb95742d4d5ebc46c405d329fbed
      https://github.com/WebKit/WebKit/commit/c5cfffe19659bb95742d4d5ebc46c405d329fbed
  Author: Xabier Rodriguez-Calvar <calvaris at igalia.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  -----------
  [GStreamer] Try to detect and recover inconsistent playing state
https://bugs.webkit.org/show_bug.cgi?id=252310

Reviewed by Philippe Normand.

A series of buffer flushings could leave pipeline in an inconsistent state: top-level bin in playing with sinks in
paused. This happens if flush is triggered in the middle of paused-to-playing transition which was started by gst bin
async handling of ASYNC_DONE message.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::areAllSinksPlayingForBin):
(WebCore::MediaPlayerPrivateGStreamer::checkPlayingConsistency):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/261571@main




More information about the webkit-changes mailing list