[webkit-changes] [WebKit/WebKit] bdb3dd: [GTK][WPE] Gardening `fast/inline/text-decoration-...

Vitaly Dyachkov noreply at github.com
Mon Mar 13 02:45:38 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bdb3dd05fff5eec5aa5d15a44a8831bc64c2274b
      https://github.com/WebKit/WebKit/commit/bdb3dd05fff5eec5aa5d15a44a8831bc64c2274b
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    A LayoutTests/fast/inline/resources/Gulf-regular.ttf
    M LayoutTests/fast/inline/text-decoration-underline-inline-box-offset-expected.html
    M LayoutTests/fast/inline/text-decoration-underline-inline-box-offset.html

  Log Message:
  -----------
  [GTK][WPE] Gardening `fast/inline/text-decoration-underline-inline-box-offset.html`

Unreviewed test gardening.

The result of the previous version of this test depended on the
descending of the font to which `Monospace` resolved on the platform.

To fix this, we now use a web font, which all platforms should pick up.

The test also didn't really test vertical text because the style for it
was identical in both the test and the baseline files.

The idea is to set the bottom border for horizontal text and the left
border for vertical text so that it matches the geometry of the
underline.

*
LayoutTests/fast/inline/text-decoration-underline-inline-box-offset-expected.html:
*
LayoutTests/fast/inline/text-decoration-underline-inline-box-offset.html:

Canonical link: https://commits.webkit.org/261565@main




More information about the webkit-changes mailing list