[webkit-changes] [WebKit/WebKit] 6ef716: Split RemoteLayerBackingStore into separate classe...

mattwoodrow noreply at github.com
Sun Mar 12 14:15:43 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ef716ad7cfad1eb20deb1b5075afbb8fb8ed0c5
      https://github.com/WebKit/WebKit/commit/6ef716ad7cfad1eb20deb1b5075afbb8fb8ed0c5
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2023-03-12 (Sun, 12 Mar 2023)

  Changed paths:
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp

  Log Message:
  -----------
  Split RemoteLayerBackingStore into separate classes for Web process and UI process.
https://bugs.webkit.org/show_bug.cgi?id=253683

Reviewed by Simon Fraser.

The code and data members for each process are entirely separate, and so have them intermingled in a single class makes the code harder to understand.
This splits the UI process subset into a new class, RemoteLayerBackingStoreProperties.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::encode const):
(WebKit::RemoteLayerBackingStoreProperties::decode):
(WebKit::RemoteLayerBackingStoreProperties::layerContentsBufferFromBackendHandle):
(WebKit::RemoteLayerBackingStoreProperties::applyBackingStoreToLayer):
(WebKit::RemoteLayerBackingStore::decode): Deleted.
(WebKit::RemoteLayerBackingStore::layerContentsBufferFromBackendHandle): Deleted.
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer): Deleted.
(WebKit::RemoteLayerBackingStore::Parameters::encode const): Deleted.
(WebKit::RemoteLayerBackingStore::Parameters::decode): Deleted.
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::layerContentsType const):
(WebKit::RemoteLayerTreeHost::asyncSetLayerContents):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):

Canonical link: https://commits.webkit.org/261552@main




More information about the webkit-changes mailing list