[webkit-changes] [WebKit/WebKit] 04e2f8: Validate identifier before creating WebsiteDataStore
Sihui
noreply at github.com
Fri Mar 10 18:53:29 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 04e2f821bf5378751d3e861f44f998ae51fb096b
https://github.com/WebKit/WebKit/commit/04e2f821bf5378751d3e861f44f998ae51fb096b
Author: Sihui Liu <sihui_liu at apple.com>
Date: 2023-03-10 (Fri, 10 Mar 2023)
Changed paths:
M Source/WTF/wtf/UUID.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
Log Message:
-----------
Validate identifier before creating WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=253667
rdar://106514136
Reviewed by Alex Christensen.
NSUUID may not be converted to valid WTF::UUID, so we should validate it before creating WebsiteDataStore.
Test: WKWebsiteDataStore.DataStoreForNilIdentifier
WKWebsiteDataStore.DataStoreForEmptyIdentifier
* Source/WTF/wtf/UUID.h:
(WTF::UUID::isValid const):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore dataStoreForIdentifier:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration initWithIdentifier:]):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::dataStoreForIdentifier):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
Canonical link: https://commits.webkit.org/261536@main
More information about the webkit-changes
mailing list