[webkit-changes] [WebKit/WebKit] 14c862: [LFC][IFC][shape-outside] Support overhanging shapes

Antti Koivisto noreply at github.com
Fri Mar 10 07:38:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 14c862ab6338a88885dee7297abe779edab4afc2
      https://github.com/WebKit/WebKit/commit/14c862ab6338a88885dee7297abe779edab4afc2
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-03-10 (Fri, 10 Mar 2023)

  Changed paths:
    M Source/WebCore/layout/floats/FloatingState.cpp
    M Source/WebCore/layout/floats/FloatingState.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.cpp
    M Source/WebCore/layout/layouttree/LayoutBox.h
    M Source/WebCore/rendering/shapes/Shape.cpp
    M Source/WebCore/rendering/shapes/Shape.h
    M Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp
    M Source/WebCore/rendering/shapes/ShapeOutsideInfo.h

  Log Message:
  -----------
  [LFC][IFC][shape-outside] Support overhanging shapes
https://bugs.webkit.org/show_bug.cgi?id=253702
rdar://106548869

Reviewed by Alan Baradlay.

* Source/WebCore/layout/floats/FloatingState.cpp:
(WebCore::Layout::FloatingState::FloatItem::FloatItem):
* Source/WebCore/layout/floats/FloatingState.h:
(WebCore::Layout::FloatingState::FloatItem::shape const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::prepareFloatingState):

Set the shape when synhesizing a FloatItem from overhang.

* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::setShape):
* Source/WebCore/layout/layouttree/LayoutBox.h:
* Source/WebCore/rendering/shapes/Shape.cpp:
(WebCore::createInsetShape):
(WebCore::createCircleShape):
(WebCore::createEllipseShape):
(WebCore::createPolygonShape):
(WebCore::Shape::createShape):
(WebCore::Shape::createRasterShape):
(WebCore::Shape::createBoxShape):
* Source/WebCore/rendering/shapes/Shape.h:

Make Shapes refcounted (simpler than making them copyable).

* Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::makeShapeForShapeOutside):
* Source/WebCore/rendering/shapes/ShapeOutsideInfo.h:

Canonical link: https://commits.webkit.org/261499@main




More information about the webkit-changes mailing list