[webkit-changes] [WebKit/WebKit] bb8532: [LFC][IFC][shape-outside] Sample the shape to find...

Antti Koivisto noreply at github.com
Fri Mar 10 05:52:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb853296ed795675971e443a7fccf1aff00a3d62
      https://github.com/WebKit/WebKit/commit/bb853296ed795675971e443a7fccf1aff00a3d62
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-03-10 (Fri, 10 Mar 2023)

  Changed paths:
    M Source/WebCore/layout/floats/FloatingContext.cpp

  Log Message:
  -----------
  [LFC][IFC][shape-outside] Sample the shape to find the first position where content fits
https://bugs.webkit.org/show_bug.cgi?id=253697
rdar://106545300

Reviewed by Alan Baradlay.

If line content doesn't fit at all we should sample the shape until we find the next line position where it does.
Currently we just move directly to the float bottom.

* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::constraints const):

In the shape case provide a bottom 1px down from the current position. We'll try again at that position if the content doesn't fit.
Also call lineOverlapsShapeMarginBounds() before getting the shape interval. This is needed for correctness in some edge cases.

Canonical link: https://commits.webkit.org/261496@main




More information about the webkit-changes mailing list