[webkit-changes] [WebKit/WebKit] 4ae8ed: Render control characters when taking complex text...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ae8edc354b7bfdeaedf1b945b5d12871450fe0b
      https://github.com/WebKit/WebKit/commit/4ae8edc354b7bfdeaedf1b945b5d12871450fe0b
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-03-10 (Fri, 10 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/fast/text/zero-width-characters-complex-script.html
    A LayoutTests/platform/glib/fast/dom/52776-expected.png
    M LayoutTests/platform/glib/fast/dom/52776-expected.txt
    A LayoutTests/platform/glib/fast/text/fixed-pitch-control-characters-expected.png
    M LayoutTests/platform/glib/fast/text/fixed-pitch-control-characters-expected.txt
    A LayoutTests/platform/glib/fast/text/wide-zero-width-space-expected.png
    M LayoutTests/platform/glib/fast/text/wide-zero-width-space-expected.txt
    M LayoutTests/platform/gtk/TestExpectations
    R LayoutTests/platform/gtk/fast/dom/52776-expected.png
    R LayoutTests/platform/gtk/fast/text/fixed-pitch-control-characters-expected.png
    R LayoutTests/platform/gtk/fast/text/wide-zero-width-space-expected.png
    R LayoutTests/platform/wpe/fast/dom/52776-expected.png
    R LayoutTests/platform/wpe/fast/text/wide-zero-width-space-expected.png
    M Source/WebCore/platform/graphics/ComplexTextController.cpp
    M Source/WebCore/platform/graphics/WidthIterator.cpp

  Log Message:
  -----------
  Render control characters when taking complex text code path
https://bugs.webkit.org/show_bug.cgi?id=153941

Reviewed by Carlos Garcia Campos.

The spec says: "Control characters (Unicode category Cc)—other than
tabs (U+0009), line feeds (U+000A), carriage returns (U+000D) and
sequences that form a segment break—must be rendered as a visible glyph"

When taking simple text code path, glyphs of these characters are replaced
with `.notdef` glyph. Let's do the same for complex text path as well.

* LayoutTests/platform/gtk/TestExpectations:
* Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

Canonical link: https://commits.webkit.org/261493@main