[webkit-changes] [WebKit/WebKit] 197660: Worklet.prototype.constructor is incorrect
Chris Dumez
noreply at github.com
Thu Mar 9 19:17:17 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1976601ac16287ba145d2457bafb212860d59255
https://github.com/WebKit/WebKit/commit/1976601ac16287ba145d2457bafb212860d59255
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-03-09 (Thu, 09 Mar 2023)
Changed paths:
A LayoutTests/fast/worklets/worklet-constructor-expected.txt
A LayoutTests/fast/worklets/worklet-constructor.html
M LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt
M Source/WebCore/worklets/Worklet.idl
Log Message:
-----------
Worklet.prototype.constructor is incorrect
https://bugs.webkit.org/show_bug.cgi?id=253666
Reviewed by Don Olmstead.
The bindings generator was generating the property table for the prototype
correctly and it contained the "constructor" property as expected. However,
this property table was unused because Worklet was incorrectly annotated
with "Global=Worklet" in the IDL. As a result, Worklet.prototype.contructor
would be the Object constructor.
This was found due to a build warning indicating that
JSWorkletPrototypeTableValues was unused.
* LayoutTests/fast/worklets/worklet-constructor-expected.txt: Added.
* LayoutTests/fast/worklets/worklet-constructor.html: Added.
* Source/WebCore/worklets/Worklet.idl:
Canonical link: https://commits.webkit.org/261483@main
More information about the webkit-changes
mailing list