[webkit-changes] [WebKit/WebKit] 97530a: Cherry-pick 1c291a95fe75. rdar://problem/106407998

Sihui noreply at github.com
Thu Mar 9 13:04:14 PST 2023


  Branch: refs/heads/safari-7616.1.6-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 97530a9da6c56d212cd5bc277888b4aeda551fcf
      https://github.com/WebKit/WebKit/commit/97530a9da6c56d212cd5bc277888b4aeda551fcf
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm

  Log Message:
  -----------
  Cherry-pick 1c291a95fe75. rdar://problem/106407998

    _removeDataStoreWithIdentifier should fail when the data store is being used by web page
    https://bugs.webkit.org/show_bug.cgi?id=253555
    rdar://106407998

    Reviewed by Chris Dumez.

    To avoid undefined behaviors and unexpected results, we don't allow data store to be removed while it is being used by
    web page.

    API Test: WKWebsiteDataStore.RemoveDataStoreWithIdentifierErrorWhenInUse

    * Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
    (WebKit::WebsiteDataStore::removeDataStoreWithIdentifier):
    * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
    (WebKit::WebsiteDataStore::existingDataStoreForIdentifier):
    (WebKit::WebsiteDataStore::hasActivePages):
    * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
    (TestWebKitAPI::TEST):

    Canonical link: https://commits.webkit.org/261399@main

Canonical link: https://commits.webkit.org/261247.26@safari-7616.1.6-branch




More information about the webkit-changes mailing list