[webkit-changes] [WebKit/WebKit] 3cc2ae: [Win] Don't use FileSystemCF.cpp

Fujii Hironori noreply at github.com
Thu Mar 9 12:40:27 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3cc2ae9e348aa7ff1ff4487f812d8ba2ba2022c4
      https://github.com/WebKit/WebKit/commit/3cc2ae9e348aa7ff1ff4487f812d8ba2ba2022c4
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M Source/WTF/wtf/FileSystem.h
    M Source/WTF/wtf/PlatformWin.cmake
    M Source/WTF/wtf/cf/FileSystemCF.cpp
    M Source/WTF/wtf/win/FileSystemWin.cpp

  Log Message:
  -----------
  [Win] Don't use FileSystemCF.cpp
https://bugs.webkit.org/show_bug.cgi?id=253556

Reviewed by Don Olmstead.

WinCairo is reducing the CF dependency.

Use fileSystemRepresentation in FileSystemWin.cpp. Fixed two bugs. The
return value of upconvertedCharacters had to be retained. The return
value of WideCharToMultiByte is a string length not containing the
null character if cchWideChar is specifed.

Conditioned out stringFromFileSystemRepresentation and pathAsURL
because they are not used for Windows.

* Source/WTF/wtf/FileSystem.h:
* Source/WTF/wtf/PlatformWin.cmake:
* Source/WTF/wtf/cf/FileSystemCF.cpp:
(WTF::FileSystem::pathAsURL):
* Source/WTF/wtf/win/FileSystemWin.cpp:
(WTF::FileSystemImpl::fileSystemRepresentation):

Canonical link: https://commits.webkit.org/261459@main




More information about the webkit-changes mailing list