[webkit-changes] [WebKit/WebKit] c3827e: [buildbot] Move SFTP upload code from generate-bun...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3827e6cc0dc1f5ccca8ff43fc50544878155265
      https://github.com/WebKit/WebKit/commit/c3827e6cc0dc1f5ccca8ff43fc50544878155265
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    A Tools/CISupport/Shared/HOWTO_config_SFTP_uploads.md
    A Tools/CISupport/Shared/transfer-archive-via-sftp
    M Tools/CISupport/build-webkit-org/steps.py
    M Tools/CISupport/build-webkit-org/steps_unittest.py
    M Tools/Scripts/generate-bundle

  Log Message:
  -----------
  [buildbot] Move SFTP upload code from generate-bundle script to a new script for uploads and document it
https://bugs.webkit.org/show_bug.cgi?id=253537

Reviewed by Aakash Jain.

Remove the SFTP upload code from the script `generate-bundle`
and create a new script dedicated to do the SFTP uploads.

Adjust the buildbot steps so now a new step is added after
sucessfully executing `generate-bundle` step to upload the
bundle generated with the new script. Add also unit tests.

Add also detailed documentation about how the SSH server should
be configured to enable the uploads via SFTP from the workers
in a secure way.

The step `UploadBuiltProductViaSftp()` added on build-webkit-org/steps.py
is still not used. Is added as an example of how the step should
look if we end uploading the built-product via SFTP.

* Tools/CISupport/Shared/HOWTO_config_SFTP_uploads.md: Added.
* Tools/CISupport/Shared/transfer-archive-via-sftp: Added.
* Tools/CISupport/build-webkit-org/steps.py:
(ArchiveMinifiedBuiltProduct):
(UploadBuiltProductViaSftp):
(UploadMiniBrowserBundleViaSftp):
(UploadJSCBundleViaSftp):
(GenerateJSCBundle):
(GenerateJSCBundle.start):
(GenerateJSCBundle.evaluateCommand):
(GenerateMiniBrowserBundle):
(GenerateMiniBrowserBundle.start):
(GenerateMiniBrowserBundle.evaluateCommand):
* Tools/CISupport/build-webkit-org/steps_unittest.py:
* Tools/Scripts/generate-bundle:

Canonical link: https://commits.webkit.org/261448@main